[HOWTO] Make automatic backup of ALL MySQL / MariaSQL databases on QNAP V3.8

[fribse]

That might be a bug in the script, could you try changing the rights for the subfolders to 777?

[nevaeh]

Okay, I went ahead and used chmod on all the mysql folders in addition to the files, ran a backup manually and it still didn't clear anything. I did notice however, that every time I ran a manual backup, the script would overwrite the current days backup with the new backup, leading me to believe it may not permissions based, but possibly the code that does the compare and cleans out older backups.

I know you previously had to edit the script to account for shares with spaces in them, does the code that does the compare by chance need to be tweaked to account for that?

[fribse]

Ahh, that might be it. I'd forgotten about that, I'll have a look at that asap.

[fribse]

Still working on this, the problem is in the handling of spaces in path, as you thought.
This works

Code: Select all

/bin/rm -f `/bin/ls -t $bkup_p/mysql.daily/*  2> /dev/null | /bin/awk 'NR>'5`

This doesn't work

Code: Select all

/bin/rm -f `/bin/ls -t "$bkup_p/mysql.daily/*"  2> /dev/null | /bin/awk 'NR>'5`

It has to do with the shell embedding with `

[fribse]

Ok, got it solved, thanks to OneCD. Please test v3.7 of the script, I've done a lot of testing on the path thing, so it should be solid now.

[Salegy1]

Runs fine for me.

There are only 2 typo's for deleting old weekly and monthly backups:

Code: Select all

# # Delete old weekly backups
info "Cleaning out old backups. Keeping the last $week_ret week backups"
full="$bkup_p/mysql.weekly"
for target in $(ls -t "$full" | tail -n +$(expr $day_ret + 1)) ; do rm -f "$full/$target"; done
if [ $? != 0 ] ; then error "ereasing old weekly backups" ; fi

# Delete old monthly backups
info "Cleaning out old backups. Keeping the last $month_ret montly backups"
full="$bkup_p/mysql.monthly"
for target in $(ls -t "$full" | tail -n +$(expr $day_ret + 1)) ; do rm -f "$full/$target"; done
if [ $? != 0 ] ; then error "ereasing old montly backups" ; fi

- Line 198: " $day_ret " has to be changed in " $week_ret "
- Line 204: " $day_ret " has to be changed in " $month_ret "

Thanks for your great work!

[fribse]

Yup, just saw that as well, I'll update NOW

[fribse]

Script is fixed, darned

[nevaeh]

For some reason when I drop in the new script, it can no longer find my share name. Was something changed with how it finds the share?

Please see the attached screenshot.

[nevaeh]

For some reason when I drop in the new script, it can no longer find my share name. Was something changed with how it finds the share?

Please see the attached screenshot.

I think I figured it out....I had to add quotes to $share in the following line:
bkup_p=$($get_c "$share" path -f /etc/config/smb.conf)

[fribse]

I see, odd, I had it running here with spaces. I'll update the script right away, thankyou for the fix!

[fribse]

The script is updated now, there were a few more regression errors with quotes from when I cleaned it up. The lines handling if the 'mysql.*' folders are missing, also missed some quotes.

[nevaeh]

Just wanted to say thank you for everything! It looks to be working perfectly now.

[trendchiller]

Big thanks for that !!!

[GTunney]

Hi Fribse,

I'm trying to configure the mysql backup and have managed to get this to run manually via putty when I input the command and it runs absolutely fine.

How ever when I configure to run via cron I get an error when it tries to compress the database. any suggestions?